random crash when saving

[brakenwagen]

yet another problem since the new win 10 update GZDOOM will crash randomly when saving, (what is the deal with this update messing things up )? anybody got any ideas?

[_mental_]

Please post a crash report.

[brakenwagen]

this it

report.txt

[_mental_]

I was asking about whole CrashReport.zip file.

[brakenwagen]

ok think i got it this time

[_mental_]

That's really weird, no idea how this can happen.

Could you please try to play with the same set of files loaded using the latest devbuild ?
Saved games are not compatible with 2.4.0 although I have nothing else to suggest at the moment.

[Graf Zahl]

Where does it crash?

[_mental_]

Code: Select all

void FSavegameManager::DoSave(int Selected, const char *savegamestring)
{
	if (Selected != 0)
	{
		auto node = SaveGames[Selected];
		G_SaveGame(node->Filename.GetChars(), savegamestring);		// <-- here
	}
// ...

The value of node is some random bunch of bytes, the value Selected cannot be determined because of optimization. Probably it's out-of-bounds read caused by an invalid value passed from scripting code.