Page 1 of 1

random crash when saving

Posted: Wed Apr 19, 2017 7:58
by brakenwagen
yet another problem since the new win 10 update GZDOOM will crash randomly when saving, (what is the deal with this update messing things up :x )? anybody got any ideas?

Re: random crash when saving

Posted: Wed Apr 19, 2017 9:01
by _mental_
Please post a crash report.

Re: random crash when saving

Posted: Wed Apr 19, 2017 22:18
by brakenwagen
this it
report.txt
crash report
(32.67 KiB) Downloaded 111 times

Re: random crash when saving

Posted: Thu Apr 20, 2017 6:18
by _mental_
I was asking about whole CrashReport.zip file.

Re: random crash when saving

Posted: Fri Apr 21, 2017 7:29
by brakenwagen
ok think i got it this time

Re: random crash when saving

Posted: Fri Apr 21, 2017 9:23
by _mental_
That's really weird, no idea how this can happen.

Could you please try to play with the same set of files loaded using the latest devbuild ?
Saved games are not compatible with 2.4.0 although I have nothing else to suggest at the moment.

Re: random crash when saving

Posted: Fri Apr 21, 2017 15:58
by Graf Zahl
Where does it crash?

Re: random crash when saving

Posted: Fri Apr 21, 2017 16:28
by _mental_

Code: Select all

void FSavegameManager::DoSave(int Selected, const char *savegamestring)
{
	if (Selected != 0)
	{
		auto node = SaveGames[Selected];
		G_SaveGame(node->Filename.GetChars(), savegamestring);		// <-- here
	}
// ...
The value of node is some random bunch of bytes, the value Selected cannot be determined because of optimization. Probably it's out-of-bounds read caused by an invalid value passed from scripting code.