Since Tonemaps - Fatal Error when parsing tonemap.fp in certain situations

Bugs that have been resolved.

Moderator: Graf Zahl

Locked
AFADoomer
Posts: 43
Joined: Fri Sep 02, 2005 3:23

Since Tonemaps - Fatal Error when parsing tonemap.fp in certain situations

Post by AFADoomer »

If I toggle through the tonemaps in the menu, I get the following error when gl_tonemap is set to 3:

"Compile Shader 'shaders/glsl/tonemap.fp':
ERROR: 0:80: '' : illegal character (") (0x22)
ERROR: 0:80: '' : illegal character (") (0x22)"

I have to edit the .ini to revert the value before I can re-open the game... I'm not sure what's triggering this, but it looks like the parser is choking on the quotes around an error message (#error "Tonemap mode define is missing") in tonemap.fp.

This happens even when running the basic IWADs...

Full log dump from one occurrence:
Spoiler:
dpJudas
Developer
Developer
Posts: 798
Joined: Sat Jul 23, 2016 7:53

Re: Since Tonemaps - Fatal Error when parsing tonemap.fp in certain situations

Post by dpJudas »

Hmm, that is strange. I don't see a way how none of the defines could be set. What happens if you remove the quotes?
AFADoomer
Posts: 43
Joined: Fri Sep 02, 2005 3:23

Re: Since Tonemaps - Fatal Error when parsing tonemap.fp in certain situations

Post by AFADoomer »

dpJudas wrote:Hmm, that is strange. I don't see a way how none of the defines could be set. What happens if you remove the quotes?
If I remove the quotes, everything works as expected... I can toggle through all of the tonemaps with no issue, and they all appear to work as expected - so I'm not sure how the error statement was ever being reached in the first place.
dpJudas
Developer
Developer
Posts: 798
Joined: Sat Jul 23, 2016 7:53

Re: Since Tonemaps - Fatal Error when parsing tonemap.fp in certain situations

Post by dpJudas »

Probably some odd thing in the Intel GLSL preprocessor. I'll include a removal of the quotes in my upcoming bug fix PR.
Locked

Return to “Closed Bugs”