random crash when saving

Something not working in GZDoom that's not a bug? Is the display a bit quirky and unexpected? Post here.

Moderator: Graf Zahl

Locked
brakenwagen
Posts: 6
Joined: Fri Apr 14, 2017 7:29

random crash when saving

Post by brakenwagen » Wed Apr 19, 2017 7:58

yet another problem since the new win 10 update GZDOOM will crash randomly when saving, (what is the deal with this update messing things up :x )? anybody got any ideas?

_mental_
Developer
Developer
Posts: 255
Joined: Sun Aug 07, 2011 13:36

Re: random crash when saving

Post by _mental_ » Wed Apr 19, 2017 9:01

Please post a crash report.

brakenwagen
Posts: 6
Joined: Fri Apr 14, 2017 7:29

Re: random crash when saving

Post by brakenwagen » Wed Apr 19, 2017 22:18

this it
report.txt
crash report
(32.67 KiB) Downloaded 11 times

_mental_
Developer
Developer
Posts: 255
Joined: Sun Aug 07, 2011 13:36

Re: random crash when saving

Post by _mental_ » Thu Apr 20, 2017 6:18

I was asking about whole CrashReport.zip file.

brakenwagen
Posts: 6
Joined: Fri Apr 14, 2017 7:29

Re: random crash when saving

Post by brakenwagen » Fri Apr 21, 2017 7:29

ok think i got it this time
Attachments
CrashReport.zip
(20.2 KiB) Downloaded 9 times

_mental_
Developer
Developer
Posts: 255
Joined: Sun Aug 07, 2011 13:36

Re: random crash when saving

Post by _mental_ » Fri Apr 21, 2017 9:23

That's really weird, no idea how this can happen.

Could you please try to play with the same set of files loaded using the latest devbuild ?
Saved games are not compatible with 2.4.0 although I have nothing else to suggest at the moment.

User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Re: random crash when saving

Post by Graf Zahl » Fri Apr 21, 2017 15:58

Where does it crash?

_mental_
Developer
Developer
Posts: 255
Joined: Sun Aug 07, 2011 13:36

Re: random crash when saving

Post by _mental_ » Fri Apr 21, 2017 16:28

Code: Select all

void FSavegameManager::DoSave(int Selected, const char *savegamestring)
{
	if (Selected != 0)
	{
		auto node = SaveGames[Selected];
		G_SaveGame(node->Filename.GetChars(), savegamestring);		// <-- here
	}
// ...
The value of node is some random bunch of bytes, the value Selected cannot be determined because of optimization. Probably it's out-of-bounds read caused by an invalid value passed from scripting code.

Locked

Return to “Technical Support”