[1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Moderators: Rachael, dpJudas

User avatar
Jimmy
Stronghold Team
Posts: 776
Joined: Wed May 10, 2006 18:10
Location: Perth, WA
Contact:

[1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Jimmy » Mon Jan 09, 2017 7:37

Or so it appears. Running zoon_v3.wad with the latest official build, there are a few stalactite objects in the first room of MAP02 that in some instances appear to be shown as fullbright, as though illuminated by the fullbright floor of the liquid sector below.

The stalactite in question is on the upper-right side of this screenshot. I moved a few steps forward and the object was no longer drawn fullbright.

Image
Image

There is another on the left that seems to stay bright no matter where I position myself. Both stalactites should not be illuminated - in every other port tested: PrBoom+, GLBoom+, Eternity, ZDoom and GZDoom, this was not the case.

This image shows the placement of the thing in the editor. It overlaps the liquid slightly, but for all intents and purposes it's still in the ground sector.
Image

Config file attached, if it helps.
qzdoom-James.ini
(18.08 KiB) Downloaded 1 time

dpJudas
Developer
Developer
Posts: 784
Joined: Sat Jul 23, 2016 7:53

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by dpJudas » Mon Jan 09, 2017 8:49

After looking a bit into this, the connection is that once GL nodes are enabled the software renderer behaves like you see in QZDoom. In other words, if you enable textured automap in the menus and restart the map, then you see the same odd behavior in ZDoom and GZDoom's software mode.

So the good news is that it is not a new bug introduced by QZDoom as such, but rather made more apparent by it always using GL nodes. The interesting part is that neither GZDoom's OpenGL or the softpoly renderer displays it fullbright, so I'm not entirely sure yet what triggers it to sometimes think those sprites are fullbright.

User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7104
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Graf Zahl » Mon Jan 09, 2017 10:24

This is a known issue with the 'render things outside their own sector' feature. The code too much depends on global variables so I wasn't able to fix it.

dpJudas
Developer
Developer
Posts: 784
Joined: Sat Jul 23, 2016 7:53

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by dpJudas » Mon Jan 09, 2017 11:02

How is that feature meant to work? (theoretically, not how it is implemented)

User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7104
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Graf Zahl » Mon Jan 09, 2017 11:14

The problem is that the sprite renderer takes the brightness from the current global variable for sector brightness. But for things in other sectors that's obviously not correct. Just par for course for the software renderer.

User avatar
Jimmy
Stronghold Team
Posts: 776
Joined: Wed May 10, 2006 18:10
Location: Perth, WA
Contact:

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Jimmy » Mon Jan 09, 2017 15:39

Apologies for thinking this was strictly a QZDoom issue, I only just now saw it happening in ZDoom. I'm honestly not sure how the issue escaped me even after I tested this wad a whole bunch in ZDoom pretty much to start with.

Perhaps stating the obvious here, but the problem is not prevalent in GZDoom's hardware renderer (it still occurs in the software renderer too) or in PrBoom+, GLBoom+, or Eternity.

I think I'll, um, still move those stalactites in the map though, as it's not too late to do so.

dpJudas
Developer
Developer
Posts: 784
Joined: Sat Jul 23, 2016 7:53

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by dpJudas » Mon Jan 09, 2017 16:21

Well it IS a bug that should be fixed. My post was mostly about tracing down the origin of the bug as I've done quite a lot of refactoring of that particular codebase of late.

User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7104
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Graf Zahl » Mon Jan 09, 2017 16:26

This one was actually mentioned in the PR by ZZYZX. Like me he found no good way to work around that global variable dependency without breaking other stuff.

User avatar
Rachael
Developer
Developer
Posts: 3548
Joined: Sat May 13, 2006 10:30

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Rachael » Mon Jan 09, 2017 17:29

Slightly off-topic, but Jimmy didn't you have an account here before? :P
Spoiler: Zen Sarcasm

User avatar
Jimmy
Stronghold Team
Posts: 776
Joined: Wed May 10, 2006 18:10
Location: Perth, WA
Contact:

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Jimmy » Thu Jan 12, 2017 8:46

I did, yeah, but had to reset my password, and didn't get the e-mail to do so until just now. (Speaking of, Jimmy being my name here would be nice. :P)

User avatar
Rachael
Developer
Developer
Posts: 3548
Joined: Sat May 13, 2006 10:30

Re: [1.2.1] Zoon_v3: floor brightness affects sprites not in sector

Post by Rachael » Thu Jan 12, 2017 13:44

I changed it - but just know this is one of those few sites that allows you to change it yourself.
Spoiler: Zen Sarcasm

Post Reply

Return to “Bugs (Archive)”

Who is online

Users browsing this forum: No registered users and 1 guest