Brightmaps+Lights rendering issue

[_mental_]

Using the compatibility renderer a particular combination of dynamic lights and brightmaps causes the following issue:

armor.png (415.44 KiB) Viewed 382 times

health.png (442.81 KiB) Viewed 382 times

The bug was initially reported here. To reproduce this load lights.pk3 with SBrightmaps.pk3:

Code: Select all

-iwad doom2 -nomonsters -file lights.pk3 -file SBrightmaps.pk3 +map map01

The modern renderer is not affected.

It appeared that lights can be rendered using wrong material set, part of brightmaps pass is still applied in this case.
I made pull request with the possible fix.

[Graf Zahl]

Thanks. This was clearly the old code no longer being compatible with how things need to be done now and must have slipped through when re-adding it.