DRD Team

There's no blocker, I just wasn't sure it's finished.

To my eyes, this is as "finished" as it can get at this point in time... with the exception of models, but I'm understanding that that has to come later, because the models' normals aren't being used yet so the model lighting stuff has to come first before model AO can be added... right?

No more bugs in the rounds of testing I've done and it's as good as it can look even when compared to modern games with a similar rendering feature.

I agree with Nash, but I guess dpJudas has to give the final word.

I'll have a look later. First I need to do a little fixing on ZScript, as it turned out that casting non-constant strings to class types is totally borked.

Can this be merged over the weekends? It's been added into QZDoom for a long time by now and I've been playing with it ever since... haven't noticed any problems. :D

This one is currently blocked by Graf being busy with ZScript - I think. I wouldn't worry. It will be looked at once the workload lessens a bit.

Nash wrote:Can this be merged over the weekends? It's been added into QZDoom for a long time by now and I've been playing with it ever since... haven't noticed any problems.

No. I need at least an entire day to properly review it, and that's what keeps it out for now.

I finally found some time to test this a little.
Even with SSAO off it's still slower than without this code. Overlooking the bridge in Frozen Time I get 43 vs. 49 fps. With the various SSAO modes the frame rate will be between 36 and 33 fps but a slowdown here was to be expected. I'd still like to find out what causes the slowdown with SSAO off, though.

Never mind, it was just one test with and one without dynamic lights being loaded. This thing looks ok, I think it can be merged.

Excellent! About the earlier FPS drop that you found in the original testing round, that was because I changed the frame buffers to be textures. After you reported that, I changed it so that if SSAO is off it uses render buffers, and if its on it switches to textures.

By the way, since I know you got an upcoming release planned, if there's anything in GZDoom you'd like me to adjust for it please let me know.

I have to admit that I lost track of it because I was sick last week. So the planned Christmas release won't happen, I first need to get an idea what's still needed to do.

Thank you Graf Zahl and dpJudas! Does the implementation of this pave way for lighting for models, for after the planned release?

No, this has nothing to do with how to process dynamic lights.