Crouching with skins

Moderator: Graf Zahl

User avatar
Enjay
Developer
Developer
Posts: 4753
Joined: Tue Aug 30, 2005 23:19
Location: Scotland

Post by Enjay »

Before skin support was added, crouching would not only make you switch to the marine when crouched, you would stay as the marine when you stood up again - however, when you went to the player setup menu, your chosen skin would still appear in the preview. All seemed good in 1.0.14 when I was using it last night though.
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany

Post by Graf Zahl »

Yes, I fixed that bug when adding skin support.
User avatar
Cutmanmike
Posts: 482
Joined: Sat Sep 03, 2005 23:34

Post by Cutmanmike »

I wonder if that crouching and then changing skin and then uncrouching bug still exists like it did in that unofficial version a while back... Although really you shouldn't do that in the first place
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany

Post by Graf Zahl »

To be honest, I never checked that. It's probably still there...
User avatar
Enjay
Developer
Developer
Posts: 4753
Joined: Tue Aug 30, 2005 23:19
Location: Scotland

Post by Enjay »

What was the bug? I didn't know there was one, but I thought it could be the kind of thing that could trip stuff up, so last night I tried various combinations of skin changing: sometimes crouched, then standing up and I didn't notice any problems. I was able to change skin whilst crouched and have the new skin still correctly applied after I stood up.
User avatar
Cutmanmike
Posts: 482
Joined: Sat Sep 03, 2005 23:34

Post by Cutmanmike »

Must not exist in this one then. Thank God, because I almost wet myself when I saw my player sprite squished and tall.
User avatar
Enjay
Developer
Developer
Posts: 4753
Joined: Tue Aug 30, 2005 23:19
Location: Scotland

Post by Enjay »

None of the skins I tried had any scaling so if that is part of the issue, then it may still be a problem.
User avatar
Cutmanmike
Posts: 482
Joined: Sat Sep 03, 2005 23:34

Post by Cutmanmike »

Oh no it's not that. In some previous unofficial release with crouching, if you crouched your skin would scale vertically. If you changed skin you would revert to normal size and if you released crouch you would be stretched vertically up.

Btw can skins even have scale?
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany

Post by Graf Zahl »

Yes, skins have scale. And the scaling code has been completely rewritten so your problem should be gone.
User avatar
Cutmanmike
Posts: 482
Joined: Sat Sep 03, 2005 23:34

Post by Cutmanmike »

Rewritten scaling code? Would that allow scaling beyond 4 or is a that completley different matter?
User avatar
Cutmanmike
Posts: 482
Joined: Sat Sep 03, 2005 23:34

Post by Cutmanmike »

Two more things:

1) It isn't working for my skin. What's wrong with it? Am I missing some frames or what?

http://gothic.34sp.com/CUTSKIN.zip

2) If you hold crouch and jump the screen goes VERY jerky.
User avatar
Enjay
Developer
Developer
Posts: 4753
Joined: Tue Aug 30, 2005 23:19
Location: Scotland

Post by Enjay »

When you say "not working" how do you mean. Your crouch sprites don't show up at all? Here's one of my S_SKIN entries

Code: Select all

name = BGPA_2 
sprite = bee2
crouchsprite = bec2
The standing skin uses a full set of replacements with sprite name BEE2XXXX and the crouch is BEC2XXXX. The standing sprite has a full 8 angles wheras the crouch doubles up angles 2&8, 3&7 and 4&6. I have 3 other skins with more or less the same setup and all work.


[edit]OK, forget that, you hadn't linked to the skin when I started typing. The problem is your crouch sprites come before the S_SKIN entry in the WAD. The sprites for the skin need to come after that entry. Move it to the start of the WAD file and it works.[/edit]
User avatar
Cutmanmike
Posts: 482
Joined: Sat Sep 03, 2005 23:34

Post by Cutmanmike »

Working now, thanks.

Return to “Closed Feature Suggestions”