Page 1 of 1

r765 Sound Environment Error

Posted: Mon Apr 05, 2010 18:37
by Enjay
When I go to a map, any map, I get the following error at the console:

Code: Select all

Sound environment 0, 38 not found
This is presumably due to the new code for being able to set sound environments via MAPINFO however, I am not getting the error message in Zdoom r2272

Re: r765 Sound Environment Error

Posted: Mon Apr 05, 2010 18:42
by Graf Zahl
I don't get such errors.

Why is your default environment 38?

Re: r765 Sound Environment Error

Posted: Mon Apr 05, 2010 18:44
by Enjay
I don't know. I'm not aware of changing it. I'll dig a bit deeper.

[edit]can't see anything in any ini files and I'm using -noautoload [/edit]

Re: r765 Sound Environment Error

Posted: Mon Apr 05, 2010 18:50
by Enjay
Using a completely fresh install consisting of nothing more than the contents of the 7z and a copy of doom.wad, I still got the error on double clicking gzdoom.exe and starting on E1M1.

Re: r765 Sound Environment Error

Posted: Mon Apr 05, 2010 18:58
by Enjay
I just did a complete clean and rebuild, just in case something was lurking somewhere, then did another fresh install and the problem still persists.

[edit]and just to eliminate another possibility, a debug build also gave me the error.[/edit]

[edit2]Hmmm, there isn't even a 0, 38 defined in the reverbs lump.[/edit2]

Re: r765 Sound Environment Error

Posted: Mon Apr 05, 2010 19:14
by Enjay
This *may* be relevant. Zdoom has this in g_mapinfo.cpp

Code: Select all

DEFINE_MAP_OPTION(defaultenvironment, false)
{
	int id;

	parse.ParseAssign();
	if (parse.sc.CheckNumber())
	{ // Numeric ID XXX [, YYY]
		id = parse.sc.Number << 8;
		if (parse.CheckNumber())
		{
			id |= parse.sc.Number;
		}
	}
	else
	{ // Named environment
		parse.sc.MustGetString();
		ReverbContainer *reverb = S_FindEnvironment(parse.sc.String);
		if (reverb == NULL)
		{
			parse.sc.ScriptMessage("Unknown sound environment '%s'\n", parse.sc.String);
			id = 0;
		}
		else
		{
			id = reverb->ID;
		}
	}
	info->DefaultEnvironment = id;
}
GZdoom does not have any of the above code.

[edit]Hmm, but adding it doesn't seem to make the message go away. [/edit]


[edit2] However, adding this as well:

Code: Select all

	DefaultEnvironment = 0;
to line 268 (again, present in Zdoom but not GZdoom) makes the error go away. [/edit2]

Re: r765 Sound Environment Error

Posted: Mon Apr 05, 2010 21:12
by Graf Zahl
Hm. No idea why this file was not committed...