Page 1 of 1

[?-r1213] user shaders not work.

Posted: Sun May 15, 2011 20:22
by Dethernal
new (r1213)
Image
official (has another shader bug(one shader programm for all textures), that solved now)
Image
Spoiler: GZDoom startup log
In new version of GZDoom SVN build have not support user shaders.

Re: [?-r1213] user shaders not work.

Posted: Sun May 15, 2011 20:35
by Graf Zahl
There's nothing here for me to work on or check this with so it's useless.

Please post your map that's causing problems.

Re: [?-r1213] user shaders not work.

Posted: Sun May 15, 2011 20:40
by Dethernal
Shaders not work on all maps. This files I already sent here.

Re: [?-r1213] user shaders not work.

Posted: Sun May 22, 2011 8:34
by Dethernal
Any news? I think that changes in shader conveer for COLORMAP may broke it.

Re: [?-r1213] user shaders not work.

Posted: Wed Aug 03, 2011 14:00
by Gez
Problem detected as early as 1146...

Note that there is another problem in older revisions (up to 1145); the Y-scrolling one glitches. I'll look into that one later.

The issue seems to stem from the defaultshaders array's increased size.

Yep. r1234, commenting out all the fuzz shaders to prevent them from being added to the array fixes the issue. Which means that the glitch must be caused by some code somewhere still expecting it to have the pre-fuzz shader size.

Edit: found it. gl_shader.h:

Code: Select all

#define FIRST_USER_SHADER 5
Naughty little define!


Fixed, though just by updating the value. I'd have preferred something safer that counts how many default shaders exist, but the best place to do so would be in the shader manager's compile function, which is called long after user shaders are processed, so it wouldn't work. A reminder comment in the code will make do for now.