Page 1 of 1

[since gl rewrite] Sector_SetFade broken in GL

Posted: Tue Jan 20, 2015 21:52
by Edward-san
See the example wad I'll attach. In gzdoom 323, the foggy effect in the horizon is well defined.
Somehow, during the code rewrite, this effect broke, ie not showing anymore.

I'd like to know if the fix is possible to port in the 1.x branch, so that it'll be easier to backport over Zandronum 2.0 (which upgraded the code base to gzdoom r900), where it was noticed in games like Jumpmaze 2 (see the ticket).

Re: [since gl rewrite] Sector_SetFade broken in GL

Posted: Wed Jan 21, 2015 19:08
by Enjay
Either I'm not understanding the post or I'm not getting the problem. When I look at the test map in dev builds, and both of the official releases, the red fade to the distance looks much like the correct screenshots from that ticket page and I'm definitely not getting the sharp cutoff from the faulty pics.

Image

There is a bit of additional blurring in the above pic due to resizing and JPG but is that drastically different to what you are seeing? It looks like a reasonably smooth fade to the horizon to me.

Re: [since gl rewrite] Sector_SetFade broken in GL

Posted: Wed Jan 21, 2015 20:37
by Edward-san
See this screenshot I took with GZDoom 323. The red fog is not present. Also, you must disable texture filtering to see what I mean.

Re: [since gl rewrite] Sector_SetFade broken in GL

Posted: Wed Jan 21, 2015 21:16
by Enjay
Edward-san wrote:Also, you must disable texture filtering to see what I mean.
Ah! I was looking for an option that might do it. No filtering = no fog for me too.

Image

Re: [since gl rewrite] Sector_SetFade broken in GL

Posted: Thu Jan 22, 2015 10:32
by Graf Zahl
I had to go way, way back to 1.3(!) to see the fog. Version 1.5.06 looks precisely the same as the current version - and it's the current version that is correct. A light level of 255 should mean 'no fade in this sector' so this loooks like the result of a bugfix that was done quite some time ago.