Pull request: https://github.com/coelckers/gzdoom/pull/100 - PR #100!
Okay this is more a bug fix than a code submission, but need to fill up Code Submissions.
It fixes that DrawBlend doesn't cover the full frame buffer area anymore if the framebuffer Width/Height is changed on the fly. Easiest way to see the bug is to start windowed in some relatively low size (say, 800x600) and then maximize the window.
I'm not 100% sure if this is the correct way to update those values for all render paths. The PR is working on my Mac laptop where I tested it though.
Wrong screen flash rectangle after window resize
Moderator: Graf Zahl
-
- Developer
- Posts: 798
- Joined: Sat Jul 23, 2016 7:53
- Graf Zahl
- GZDoom Developer
- Posts: 7148
- Joined: Wed Jul 20, 2005 9:48
- Location: Germany
- Contact:
Re: Wrong screen flash rectangle after window resize
Actually, it's not 100% correct. The memcpy is needed for all render paths, only Map() and Unmap() are additionally needed for BM_DEFERRED.
-
- Developer
- Posts: 798
- Joined: Sat Jul 23, 2016 7:53
Re: Wrong screen flash rectangle after window resize
Figured there was a good chance of that, but wasn't completely sure.
By the way, the Mac version ran completely steady at 60 fps. I'm not sure it did that before switching to the Core Profile. Was positively surprised.
By the way, the Mac version ran completely steady at 60 fps. I'm not sure it did that before switching to the Core Profile. Was positively surprised.
-
- Developer
- Posts: 259
- Joined: Sun Aug 07, 2011 13:36
Re: Wrong screen flash rectangle after window resize
It did. Of course, depends on hardware, map, resolution, etc. The "reference" old renderer to compare with is still in the g1.x branch.dpJudas wrote:By the way, the Mac version ran completely steady at 60 fps. I'm not sure it did that before switching to the Core Profile. Was positively surprised.
-
- Developer
- Posts: 798
- Joined: Sat Jul 23, 2016 7:53
Re: Wrong screen flash rectangle after window resize
Must have been my Intel GPU on the PC that didn't run completely smooth then. Was good to see it run as it should.