r184 Crash on exit

[Graf Zahl]

Not unexpected but it gave me a hint about a possible solution. I think the crash is caused by the same design error. I'll address that one later. Hopefully it helps.

[Enjay]

r189 Same again.

[Graf Zahl]

Do you see any chance to reduce the amount of data so that you can send it to me? I really need a reliable scenario in which I can test this. I have addressed everything I thought could be responsible and without the ability to test this in a controlled environment I will never be able to find it.

[Graf Zahl]

Ok, one last try. If r190 doesn't do it I am out of ideas.

[Enjay]

Oh dear, r190 looks much the same to me.



I've tried a number of times to include enough data to cause the crash, but have never managed to reproduce it in a cut down version. I'll try again but I don't hold out much chance of managing it. I noticed that a couple of people were reporting problems with the KDiZD "red tunnel -> intermission map" crashing in the same way. I take it that didn't happen for you? (It happened to me, but only once.)

[Enjay]

Well, Ive been trying and trying. The best I can do is get a file which still has most of my basic resources in it and the 3 levels concerned and it only crashes most of the time, not all of the time. Cutting out the MP3 music and the models and a few other hi-resolution things has shaved about 250MB off the file. However, my worry is that, with the bug being quite sensitive, it simply won't crash on your machine even though it does it most of the time on mine. The main project only very, very rarely does not crash but this one only crashes about half the time for me.

With the 7z still being almost 60mb, it's going to take me a long time to upload (assuming that I even manage) and it will be pretty galling for it not to cause a crash with you. Is it worth me uploading it?

[Enjay]

Shit! 1 hour 7 minutes and the upload failed at 54MB. Apparently the file exceeds my webspace limit.

[Graf Zahl]

Since r190 also crashes I know one thing for sure now: Some actor seems to be removed in a way that doesn't get registered by the sound code. I think I add a full GC handler for that partiucular variable next. I see no other way to make sure that it doesn't point to old data.

[Graf Zahl]

Let's see if it helps. r191 is up.

[Enjay]

OK, well it's different. With a debug build and only 2 tries so far, I have not got a crash dialogue on exit. However, it is taking a very long time to exit. I press esc to bring up the menu, select quit, hit enter then press Y. The game screen disappears and I am left with a blank window (ie from full screen, I get to see the window frame, title bar etc, but the contents of the window are black.) for about 1 minute. Eventually I get returned to the debugger. I noticed that whilst the game is exiting during that minute, there is a bunch of stuff getting sent to the debug output, so I've saved that as a text and zipped it up.

I'll try a release build next and see what happens there.

[Graf Zahl]

Finally some progress. The long delay comes from processing the debug output. It looks like the sound code is keeping a lot of actors locked in memory.

Maybe I can get somewhere without your code now. Let's try something.

[Enjay]

Finally some progress.

That is good news.

For info (though I suspect you know this) a release version has no obvious delay when quitting.

After running the release build through my "crash procedure" 5 or 6 times, I have not had a crash. With previous builds, it would almost certainly have crashed by now.

Similarly, aside from the lengthy quit times, 6-7 tries with the debug build have not given a crash.


Should I put a build of r191 onto the DRD server, or is it best to leave it until you've done whatever else you are doing?

[Graf Zahl]

Please wait. It was quickly slapped together and some GC related code still needs to be added. This should have no impact on the memory leak though (unfortunately)

Nevertheless, I consider a memory leak a far lesser evil than a crash.

[Enjay]

OK, I'll hold off until you tell me which version should go online.

For info, I must have run through the procedure around about 20 times now, including a couple of times with r192, and I've also built my own modified version based on r191 and no crashes with any of them.

[Graf Zahl]

Good to hear. You may do a new online build once r193 is up. It will contain some necessary fixes from ZDoom.