[r296] Crash when inventory item is used (GZDA)

Bugs that have been resolved.

Moderator: Graf Zahl

User avatar
Rachael
Developer
Developer
Posts: 3651
Joined: Sat May 13, 2006 10:30

Post by Rachael »

I'll test it out and see if I can get any crashes, if I do, I'll post it here.

EDIT: Got the mod, but it appears the map is not online. Are you sure it got posted?
eliw00d
Posts: 15
Joined: Tue Feb 03, 2009 15:17

Post by eliw00d »

Sorry, it should be on there now. It's called Toxicity.

The crash occurs when you press the "Toggle Fire Mode" key. The default key should be "F".
User avatar
Enjay
Developer
Developer
Posts: 4748
Joined: Tue Aug 30, 2005 23:19
Location: Scotland
Contact:

Post by Enjay »

Well, I don't really know what to tell you. I DL's the mod and played right through the map with r300. No crash.

I assumed that all I needed was B72. However, the map had a lot of missing textures, so maybe I was wrong.




The only thing worth reporting are all these errors at the console that I get when loading your mod:

[spoiler]

Code: Select all

LoadActors: Load actor definitions.
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 51:
Unknown class name 'SidearmMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 64:
Unknown class name 'SidearmMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 67:
Unknown class name 'SidearmMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 68:
Unknown class name 'SidearmCasing'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 72:
Unknown class name 'SidearmMagEmpty'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 75:
Unknown class name 'SidearmMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 147:
Unknown class name 'DoubleBarrelMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 160:
Unknown class name 'DoubleBarrelMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 163:
Unknown class name 'DoubleBarrelMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 173:
Unknown class name 'DoubleBarrelMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 176:
Unknown class name 'DoubleBarrelMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 194:
Unknown class name 'MinigunBeltCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 206:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 211:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 216:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 217:
Unknown class name 'MinigunBeltCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 220:
Unknown class name 'MinigunBeltCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 221:
Unknown class name 'MinigunCasing'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 224:
Unknown class name 'MinigunBeltCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 225:
Unknown class name 'MinigunCasing'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 228:
Unknown class name 'MinigunBeltCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 229:
Unknown class name 'MinigunCasing'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 232:
Unknown class name 'MinigunBeltCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 233:
Unknown class name 'MinigunCasing'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 239:
Unknown class name 'MinigunBeltCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 248:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 253:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 257:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 265:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 272:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 280:
Unknown class name 'MinigunCoolDown'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 363:
Unknown class name 'PlasmaBall_'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 384:
Unknown class name 'BFGMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 397:
Unknown class name 'BFGMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 402:
Unknown class name 'BFGBall4'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 403:
Unknown class name 'BFGMagCheck'
Script warning, "GZDA-B72.zip:decorate/marines.txt" line 410:
Unknown class name 'BFGMagCheck'
Script warning, "GZDA-B72.zip:decorate/daemons.txt" line 162:
Unknown class name 'microgunCoolDown'
Script warning, "GZDA-B72.zip:decorate/daemons.txt" line 172:
Unknown class name 'microgunCoolDown'
Script warning, "GZDA-B72.zip:decorate/daemons.txt" line 177:
Unknown class name 'microgunCoolDown'
Script warning, "GZDA-B72.zip:decorate/daemons.txt" line 201:
Unknown class name 'microgunCoolDown'
Script warning, "GZDA-B72.zip:decorate/daemons.txt" line 206:
Unknown class name 'microgunCoolDown'
Script warning, "GZDA-B72.zip:decorate/daemons.txt" line 210:
Unknown class name 'microgunCoolDown'
Script warning, "GZDA-B72.zip:decorate/daemons.txt" line 218:
Unknown class name 'microgunCoolDown'
Script warning, "GZDA-B72.zip:decorate/1_chainsaw.txt" line 35:
Unknown class name 'Chainsaw_'
Script warning, "GZDA-B72.zip:decorate/1_chainsaw.txt" line 68:
Unknown class name 'CheapAlert'
Script warning, "GZDA-B72.zip:decorate/1_chainsaw.txt" line 79:
Unknown class name 'CheapAlert'
Script warning, "GZDA-B72.zip:decorate/1_chainsaw.txt" line 84:
Unknown class name 'CheapAlert'
Script warning, "GZDA-B72.zip:decorate/1_chainsaw.txt" line 98:
Unknown class name 'CheapAlert'
Script warning, "GZDA-B72.zip:decorate/1_chainsaw.txt" line 103:
Unknown class name 'CheapAlert'
Script warning, "GZDA-B72.zip:decorate/3_supershotgun.txt" line 160:
Unknown class name 'CheapAlert'
Script warning, "GZDA-B72.zip:decorate/3_shotgun.txt" line 10:
Unknown class name 'ShellBandolier'
Script warning, "GZDA-B72.zip:decorate/4_microgun.txt" line 56:
Unknown class name 'RifleCasingSmoke'
Script warning, "GZDA-B72.zip:decorate/4_microgun.txt" line 58:
Unknown class name 'RifleCasingSmoke'
R_Init: Init Doom refresh subsystem.
Script error, "GZDA-B72.zip:fontdefs.txt" line 14:
STTSLASH: Unable to find texture in font definition for STATUSFONT
[/spoiler]
eliw00d
Posts: 15
Joined: Tue Feb 03, 2009 15:17

Post by eliw00d »

Did you try toggling the "Fire Mode"? With the "F" key? The map and mod itself are fine, but for some reason it crashes on this map.

I have never had it crash before until I tried this map with my mod, but lizardcommando also said he had a crash. His circumstances are unknown as he hasn't responded to my PM in the ZDoom forums.

Also, the error messages you discovered are pointing to inventory items that no longer exist. I haven't updated the Marines.txt in a long time, so that is probably why.

The missing textures is actually because he has a DarkenTextures.wad that goes with it. I can upload that, too, but it shouldn't have an effect on this crash.
User avatar
Enjay
Developer
Developer
Posts: 4748
Joined: Tue Aug 30, 2005 23:19
Location: Scotland
Contact:

Post by Enjay »

eliw00d wrote:Did you try toggling the "Fire Mode"? With the "F" key?
No I didn't. However, I just have and insta-crash with, as you said, no GZDoom dialogue (BTW toggle fire mode was not bound to a key when I loaded the mod).

I don't have a debug build of r300 ATM, but I'll do that and see what happens.
eliw00d
Posts: 15
Joined: Tue Feb 03, 2009 15:17

Post by eliw00d »

Ah, I think I have it with a default bind in my current (unreleased) build. But that shouldn't have an effect on the crash, either. The decorate for the "Toggle Fire Mode" has not been changed since B72.
User avatar
Enjay
Developer
Developer
Posts: 4748
Joined: Tue Aug 30, 2005 23:19
Location: Scotland
Contact:

Post by Enjay »

Don't know how much help this will be:

Image

Pressing retry seemed to get things very stuck. I just heard a second or so of music repeating over and over and I did not get returned to GZdoom.

With Abort, I got this (eventually)

Image
Last edited by Enjay on Tue Feb 17, 2009 0:29, edited 1 time in total.
eliw00d
Posts: 15
Joined: Tue Feb 03, 2009 15:17

Post by eliw00d »

Thank you, Enjay! I hope this helps Graf.
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Post by Graf Zahl »

I got there already myself. My guess is that you used an ACS library without declaring it as such. Since the source for it isn't there I can't confirm for sure but this looks like the typical result of it: an ACS string access error.
eliw00d
Posts: 15
Joined: Tue Feb 03, 2009 15:17

Post by eliw00d »

Hmm. Why would it only happen on this map, though? I can show you my ACS file if it will help pinpoint the target.
User avatar
Rachael
Developer
Developer
Posts: 3651
Joined: Sat May 13, 2006 10:30

Post by Rachael »

Might be a mistake on this map only. From the way Graf says it, though, it sounds like a pretty common error.
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Post by Graf Zahl »

Undeclared libraries only crash when 2 things combined are present:

1. The map uses ACS itself
2. The library contains strings.

ACS libraries contain special prefixing code for strings that's only generated when the #library directive is being used. As long as the map itself does not contain ACS this doesn't matter because no prefix means 0 which logically is the prefix of the map script. But here the library is script index 1 so the unprefixed string indices mean that the ACS interpreter is trying to get them from the map script.

This is a design flaw in the ACS loader (which should have refused to load such libraries) and I'm not sure if it can be fixed without creating much worse problems.
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Post by Graf Zahl »

I just saw your script source. Problem confirmed I'd say. Add a #library directive at the top and the crash should go away.
eliw00d
Posts: 15
Joined: Tue Feb 03, 2009 15:17

Post by eliw00d »

Awesome! Thanks! But..

#library by itself? Or #library GZDA.o? Or what?
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Post by Graf Zahl »

#library "name". In this case #library "gzda".
Locked

Return to “Closed Bugs”