1.2.1 compile error

jengelh · Post by **jengelh** » Tue Mar 17, 2009 19:40

Hi,

I am seeing a compile error on GNU systems. The include directory for the shipped LZMA code seems to be missing, though this error does not trigger with ZDoom 2.3.1, which is built the same way.

Code: Select all

[ 36%] Building CXX object src/CMakeFiles/zdoom.dir/sdl/i_system.o
cd /usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/obj/src && /usr/bin/c++   -DHAVE_FPU_CONTROL -DNEED_STRUPR=1 -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -D__forceinline=inline -march=i586 -mtune=i686 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -O2 -g   -Wall -Wno-unused -fno-strict-aliasing -O3 -DNDEBUG  -fno-rtti -fomit-frame-pointer -I/usr/include/SDL -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/opt/libfmodex-4.23/include/fmodex -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/obj/src -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/. -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/g_doom -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/g_heretic -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/g_hexen -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/g_raven -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/g_strife -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/g_shared -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/fragglescript -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/Linux -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/oplsynth -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/sound -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/textures -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/thingdef -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/timidity -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/xlat -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/../snes_spc/snes_spc -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/../gdtoa -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/../dumb/include -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/obj/gdtoa -I/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/sdl   -o CMakeFiles/zdoom.dir/sdl/i_system.o -c /usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/sdl/i_system.cpp


In file included from /usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/./w_wad.h:26,
                 from /usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/sdl/i_main.cpp:56:
/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/./files.h:7:21: error: LzmaDec.h: No such file or directory
In file included from /usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/./w_wad.h:26,
                 from /usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/sdl/i_main.cpp:56:
/usr/src/packages/BUILD/zdoom-2.3.1_1.2.01/gzdoom/src/./files.h:261: error: â€˜CLzmaDecâ€™ does not name a type
make[2]: *** [src/CMakeFiles/zdoom.dir/sdl/i_main.o] Error 1
make[1]: *** [src/CMakeFiles/zdoom.dir/all] Error 2
make: *** [all] Error 2

hungerfish · Post by **hungerfish** » Sun Mar 22, 2009 19:19

Same here

Also on latest svn.

zdoom builds fine.

Post by **Graf Zahl** » Sun Mar 22, 2009 22:08

I can't test it so if somebody could fix the build files I'd appreciate it.

hungerfish · Post by **hungerfish** » Mon Mar 23, 2009 1:31

Hmm, well it seems like its having problems with locating the lzma stuff.
I checked through CMakeLists.txt , comparing with reg. zdoom, but found nothing strange.
make lzma also works fine, and all the object files seem to get created analog to a zdoom compile.

Where else can one look?

jengelh · Post by **jengelh** » Mon Mar 23, 2009 21:01

I believe this is it.

Code: Select all

--- zdoom/src/CMakeLists.txt   2009-03-17 18:42:32.889967501 +0100 (svn rev 1485)
+++ gzdoom/src/CMakeLists.txt  2009-03-17 18:47:04.647966731 +0100 (svn rev 312)
...
-include_directories( "${ZLIB_INCLUDE_DIR}" "${JPEG_INCLUDE_DIR}" "${FMOD_INCLUDE_DIR}" "${BZIP2_INCLUDE_DIR}" "${LZMA_INCLUDE_DIR}" )
+include_directories( "${ZLIB_INCLUDE_DIR}" "${JPEG_INCLUDE_DIR}" "${FMOD_INCLUDE_DIR}" )
...

Patch below, this time in -p0 unidiff format.

hungerfish · Post by **hungerfish** » Mon Mar 23, 2009 22:16

Yup, build working fine again

Thank you!