[1.2.0 and 1.2.01] Hub-like behaviour in non-hub cluster

[Ixnatifual]

Reference: http://forum.zdoom.org/viewtopic.php?f= ... 50#p419334

In Titan 2, maps 1-6 are in the same cluster, which is not defined as a hub. However when you move from one map to the next in this cluster, in 1.2.0 or 1.2.01 you are no longer shown a tally screen, and any keys you picked up from the previous map are retained, as if it was a hub.

The WAD is a bit messy to look at in XWE, but the MAPINFO lump looks like this:
[spoiler]// MAPS

map map01 "The Pits"
levelnum 1
sky1 SKY2 0.0
music greatwhi
PAR 330
next MAP02
cluster 1

map map02 "Demon's Furnace"
levelnum 2
sky1 SKY2 0.0
music sstalker
PAR 450
next MAP03
cluster 1

map map03 "Tartarus"
levelnum 3
sky1 SKY2 0.0
music doomedfo
PAR 690
next MAP04
cluster 1

map map04 "Goat Mansion"
levelnum 4
sky1 SKY2 0.0
music strangep
PAR 390
next MAP05
cluster 1

map map05 "Cacoastrum"
levelnum 5
sky1 SKY3 0.0
music myisland
PAR 690
next MAP06
cluster 1

map map06 "City of Demons"
levelnum 6
sky1 SKY3 0.0
music stomping
next MAP07
PAR 1080
secretnext MAP10
cluster 1

map map07 "Bowels of Gehinom"
levelnum 7
sky1 SKY3 0.0
music burninfl
PAR 1110
next MAP08
cluster 2

map map08 "Realm of the Unseen"
levelnum 8
sky1 SKY3 0.0
music comawhit
PAR 840
next MAP09
cluster 2

map map09 "Coliseum of the Damned"
levelnum 9
sky1 SKY3 0.0
music warmachi
PAR 660
next MAP10
cluster 4

map map10 "Mineral Storage"
levelnum 10
sky1 SKY3 0.0
music refinery
PAR 480
next MAP07
cluster 3

map titlemap "Title"

// CLUSTERS

clusterdef 4
flat RROCK19
music warmachi
exittext
"AS THE BODY OF THE SUPREME FIEND WHO HAD
ORCHESTRATED YOUR IMPRISONMENT IN HELL
COLLAPSES IN A BLOODY HEAP BEFORE YOUR
FEET, YOU CLIMB ITS NEST TO REACH THE LAST
PORTAL - THE PORTAL LEADING BACK TO EARTH.

AS YOU ENTER THE GATEWAY, THE MASSIVE
STRUCTURE OF THE HELLISH COLISEUM BEGINS
TO FALL APART, THE UNHOLY REALITY FALLING
IN ON ITSELF. YOU EMERGE SAFELY ON THE
OTHER SIDE AS THE GATEWAY SHUTS BEHIND YOU.

YOU OPEN YOUR EYES AND SEE GREEN GRASS,
AND FIND YOURSELF SURROUNDED BY A MASSIVE
CITYSCAPE. YOU BREATHE IN THE ATMOSPHERE
YOU CAN BARELY REMEMBER.

THIS IS EARTH. AND YOU ARE HOME."



clusterdef 3
flat FLAT4
entertext
"THE LIFT GOES EVER UP, AS THE HUMAN-BUILT
SURROUNDINGS MAKES YOU WONDER WHETHER THIS
IS AN ACTUAL WAY OUT OF HELL OR SIMPLY
ANOTHER TRAP.

AS THE ELEVATOR COMES TO A HALT, YOU STEP
OUT IN WHAT APPEARS TO BE A CORRIDOR OF
A UNION AEROSPACE CORPORATION MOON BASE.
BUT SOMETHING ABOUT THIS PLACE SEEMS
DISTURBINGLY BOTH FAMILIAR AND UNKOWN."[/spoiler]
It seems to work well enough in the first Titan though. Does my MAPINFO look alright? At least it seems to work with previous versions of GZDoom and also with ZDoom. Notice I have no clusterdefs for clusters 1 and 2, and these are the problem clusters. If you exit MAP07 to MAP08 (both cluster 3) the tally screen comes up, and your keys are lost appropriately. Perhaps non-defined clusters default to hubs in 1.2+, where they previously defaulted to non-hubs?

[Enjay]

I just posted this over at Zdoom. I hadn't realised that this bug report had quite so much detail in it.

However, I've just been trying to replicate this problem in other WADs and failed. In all the WADs that I tried, original levels, add on missions, new MAPINFO format, old MAPINFO format, with intermission, without intermission and a variety of exit line types, provided that the levels were not in a hub, keys were always stripped from my inventory.

So, I decided to look in Titan2's MAPINFO (some may say that I should have looked there first ). Anyway, I noticed that a lot of the maps are allocated to cluster 1 or 2. However, as far as I can see, nothing defines those clusters and the only ones defined in the MAPINFO are clusters 3 and 4. I suspect that is where the error is creeping in and perhaps older versions of (G)Zdoom (pre new MAPINFO) are handling this omission differently.

[edit]And, indeed, adding cluster definitions for those clusters fixes the key problem. [/edit]

So, yeah, the basic problem does indeed seem to be that there are a bunch of maps in clusters 1 and 2 but these clusters are not defined in MAPINFO.

[Graf Zahl]

Fixed. Implicitly defined clusters were not initialized when being created.