r515 and before

[Enjay]

Not sure how far this goes back, but more SVN revisions than I currently have on my machine but the official release does not crash.

Loading the following mapinfo causes a crash.

Code: Select all

clearskills

skill Medium
{
AmmoFactor = 1
DamageFactor = 1
aggressiveness = 0
SpawnFilter = "Normal"
PicName = "M_HURT"
ACSreturn = 2
Key = m
}

Commenting out clearskills stops the crash.

The crash does not happen in Zdoom. The crash happens with an old-format mapinfo and this newer format one.

[Graf Zahl]

Ugh...

Fixed.

The actual bug is present in ZDoom, too, but there it didn't cause a crash.

The skill-specific GetReplacement code was missing some crucial checks and not fully working. It just got triggered this badly here because the code that initializes the dynamic lights needed to check Dehacked replacements but this happened before some stuff was fully initialized and ran head on into one of the errors in that code.