Overlooked ZDoom changes, working x64 MSVC config diff patch

Moderator: Graf Zahl

Locked
Aroenai
Posts: 11
Joined: Sat Jul 24, 2010 7:41

Overlooked ZDoom changes, working x64 MSVC config diff patch

Post by Aroenai »

I spotted a few old changes in the ZDoom source that GZDoom overlooked, and figured I'd beg and plead for the 64-bit compile patch to be included in the SVN as well :D Compiles fine and works as far as I can tell, but I'm using VC2008 so it had to be converted before I could compile, diff is based on 2005 still.
Attachments
gzdoom_64-bit_diff.zip
(25.87 KiB) Downloaded 108 times
User avatar
Gez
Developer
Developer
Posts: 1399
Joined: Mon Oct 22, 2007 16:47

Re: Overlooked ZDoom changes, working x64 MSVC config diff p

Post by Gez »

Care to give the ZDoom revision numbers for these changes?
I'm seeing 1452, 1461, 1468, 1545, 1780, 2092, is that all?
Aroenai
Posts: 11
Joined: Sat Jul 24, 2010 7:41

Re: Overlooked ZDoom changes, working x64 MSVC config diff p

Post by Aroenai »

You mean the revisions with the changes that didn't get merged in? I didn't keep a record of the revisions with the changes, I was just using WinDiff and glancing through the logs on TortoiseSVN to make sure they were correct, it should be identical to the r2448 zdoom sources with the exception of the #ifdef lines on the hqnx scalers from gzdoom (it won't compile on x64). Most of them were on the libraries, like zipdir and lzma so they shouldn't be hard to find since they aren't modified much. All I remember is that one of them went as far back as r1400-something.
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Re: Overlooked ZDoom changes, working x64 MSVC config diff p

Post by Graf Zahl »

I did a quick check of the libraries and updated everything I could except zipdir. I never bothered to change the project for the new version so it still needs the old one.
Aroenai
Posts: 11
Joined: Sat Jul 24, 2010 7:41

Re: Overlooked ZDoom changes, working x64 MSVC config diff p

Post by Aroenai »

Thank you, I really appreciate your work :) What about 2312, 1452, and the changes in gzdoom.vcproj? It's missing a few file references and still including ones that no longer exist.

Forgive my ignorance :oops: , but why can't zipdir be updated and the 64-bit option be fixed? They compile without any errors and I've already provided the patch file with the changes so they can easily be reviewed if anything is incorrect. If the files are identical to zdoom now, doesn't that make updating less of a headache later?

Edit: attached build log and link to the binary
gzdoom64-r852-bin.zip
Attachments
gzdoom-r852.zip
.patch file with the remaining changes from zdoom and the 64-bit project fixes for gzdoom.vcproj
(25.67 KiB) Downloaded 104 times
gzdoom64-r852_build_log.txt
Build Log:
DirectX June 2010 SDK (ddraw.lib depreciated, not linked in build)
FMOD 4.26.26
yasm 1.0.1
Visual Studio Team System 2008
(100.3 KiB) Downloaded 106 times
Locked

Return to “Closed Feature Suggestions”