g1.8.1-303-gcb74dd9 various crashes with my files

[Enjay]

Not sure if anyone can help, but here goes...

With my own (slightly) modified version of g1.8.1-303-gcb74dd9, when I quit GZDoom, there is a crash dialogue waiting for me at the desktop.

Probably useless crash report:

CrashReportNJ.zip

(29.2 KiB) Downloaded 56 times

If I load all the mod project files on top of doom2.wad using ZDL, an unmodified GZDoom (same version as the one posted on the git builds site) crashes in a similar way:

CrashReportGZD.zip

(28.87 KiB) Downloaded 54 times

So far I haven't been able to isolate things any better but I will try. If I can get a cut down file that shows the problem, I will post it.

[edit] Hmmm... loading all the files and then removing them one by one doesn't get rid of the crash until I only have one file loaded. Problem is, I can't get a situation where the same files, and only those files, consistently cause the crash. When everything is loaded, I always get the crash. When one file is loaded, I never get the crash. Working out which files need to be loaded, however, seems to be tricky. Unfortunately, some files depend on others. GZDoom can't start with some of them loaded without others also being loaded so that's muddying the waters too. [/edit]

[Enjay]

Just in case it means anything (probably not), I compiled a copy from 29th September with VS2005 and it worked. I then converted the project to 2008 (using the tool that came with VS2008 express) and compiled with VS2008. It also worked without crashing.

So, it looks like the crash might be due to something that has changed since the above version rather than just the migration to the new compiling environment.

gzdoom-g1.8.1-285-g834678a.7z from the nightly builds does not crash either.

[Enjay]

I *think* I have identified where the problem crept in (bearing in mind that I'm not particularly adept with git). Reverting the changes made here:

Code: Select all

SHA-1: a72b94e80caf80da3049fbf8a388159f5b8d9f70

* - fixed: Warped textures were recreated each time they were bound.
- fixed: Models were never freed.

Stops the crash happening.

This is what I did...



Then compiled and the crash stopped.

[Graf Zahl]

It's obviously the models. The warping texture thing can't produce crashes. Do you have a small demo mod that produces the crash?
Obviously I don't want the memory leak to stay in the code.

[Kappes Buur]

303 crashes for me when quitting Rex's Paranoid, Tormentor's strnghld_v1 and one of my example pwads with models.

[Enjay]

Yup, that chair example PK3 gives me the exit crash too. Thanks.

[Graf Zahl]

Now it's fixed. Some data in the models was deleted twice and of course this couldn't work.