GZDoom r1590 broke 3D Weapon Support

[Mirrorman95]

Here are the steps required to replicated the problem I'm having with GZDoom:
1. Download GZDoom 0.1.9 and run it on Mountain Lion, or download GZDoom r1590 and run it on Windows.
2. Download http://www-personal.umich.edu/~jimw/Cla ... Models.pk3 to the GZDoom folder.
3. Edit the GZDoom.ini file in that folder to include [Global.Autoload] Path=GZ-Models.pk3
4. Play Freedoom, or any other IWAD that utilizes Doom's weapons.

When loading the pk3 previous versions of GZDoom, I would see 3D models replacing the game's 2D sprites. In the latest version, all HUD weapons and ammo pickups are invisible.

I don't mind the issue, I just can't use the current version of GZDoom until the problem is fixed.

The given model pack has the same issue on the latest Windows build of GZDoom, r1590, as it does on the latest Mac OS X build of GZDoom, 0.1.9.

[Enjay]

For some reason, GZDoom (r1594) is not finding stuff specified in the modeldefs:

[spoiler]

Code: Select all

FindModel: 'ComputerMap_Screen.md2' not found
ComputerMap_Screen.md2: model not found
FindModel: 'ComputerMap_Glow.md2' not found
ComputerMap_Glow.md2: model not found
FindModel: 'ComputerMap_Screen.md2' not found
ComputerMap_Screen.md2: model not found
FindModel: 'ComputerMap_Glow.md2' not found
ComputerMap_Glow.md2: model not found
FindModel: 'ComputerMap_Screen.md2' not found
ComputerMap_Screen.md2: model not found
FindModel: 'ComputerMap_Glow.md2' not found
ComputerMap_Glow.md2: model not found
FindModel: 'ComputerMap_Screen.md2' not found
ComputerMap_Screen.md2: model not found
FindModel: 'ComputerMap_Glow.md2' not found
ComputerMap_Glow.md2: model not found
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_Weapon.png' not found in 'DoomPlayer'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'ScriptedMarine'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineFist'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineBerserk'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineChainsaw'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarinePistol'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineShotgun'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineSSG'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineChaingun'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineRocket'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarinePlasma'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineRailgun'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Marine_squished.png' not found in 'MarineBFG'
FindModel: 'Models/Items/Armour/Marine_squished.md2' not found
Marine_squished.md2: model not found
Skin 'Squished.png' not found in 'RealGibs'
FindModel: 'Models/Decoration/Plasma/Squished.md2' not found
Squished.md2: model not found
FindModel: 'Models/Decoration/Plasma/Squished.md2' not found
Squished.md2: model not found
Skin 'Squished.png' not found in 'Gibs'
FindModel: 'Models/Decoration/ExplosiveBarrel/MediumLamp_Disc.md2' not found
MediumLamp_Disc.md2: model not found
Skin 'MediumLamp_Disc.tga' not found in 'TechLamp2'
FindModel: 'Models/Weapons/Hud/CHAINGUN/ChainsawBlade.md3' not found
ChainsawBlade.md3: model not found
FindModel: 'Models/Weapons/Hud/CHAINGUN/ChainsawHand.md3' not found
ChainsawHand.md3: model not found
Skin 'doomchainsawc.png' not found in 'Chainsaw'
Skin 'Hands.png' not found in 'Chainsaw'
FindModel: 'Models/Weapons/Hud/CHAINGUN/ChainsawBlade.md3' not found
ChainsawBlade.md3: model not found
FindModel: 'Models/Weapons/Hud/CHAINGUN/ChainsawHand.md3' not found
ChainsawHand.md3: model not found
Skin 'doomchainsawc.png' not found in 'Chainsaw'
Skin 'Hands.png' not found in 'Chainsaw'
FindModel: 'Models/Weapons/Hud/CHAINGUN/ChainsawBlade.md3' not found
ChainsawBlade.md3: model not found
FindModel: 'Models/Weapons/Hud/CHAINGUN/ChainsawHand.md3' not found
ChainsawHand.md3: model not found
Skin 'doomchainsawc2.png' not found in 'Chainsaw'
Skin 'Hands.png' not found in 'Chainsaw'

[/spoiler]

Whereas the above error messages don't appear in v1.7.1.

However, I'm not sure what it is about these modeldefs that mean they aren't working. I've tested a few of my own mods and the models there are working just fine (albeit that there are no HUD models in my mod - but this problem isn't just affecting the HUD models in "GZ-Models.pk3").

[Gez]

I doubt it's r1590 that broke it. I could have suspected r1556, but apparently it's already broken in r1542, so that's not it. Works in r1534. Gonna try r1538 next.

Edit: broken in r1538. Trying r1536.

Re-Edit: r1536 works. Trying r1537. I suspect, based on Enjay's post, that the problem comes from the sc_man parser change.

Edit Cubed: r1537 is where it was broken, yes.

Edit the Fourth: reverting just the sc_man_scanner files to r1536 makes the file work again, so I guess it's pretty much confirmed it's the scanner change that's responsible.

[Gez]

So, the problem here is that some of the lines contain a whitespace character 0xA0. When it's loaded as signed char, the sign bit is ignored and it turns into the value 0x20; which corresponds to space, so it's not tokenized. Ever since extended ASCII char support was added, however, the sign bit is no longer trimmed. Instead of parsing as "Path" (or whatever else), it parses it as " Path"... So it doesn't recognize that it's a path, and it doesn't change the path, and it doesn't find the model.

In short, it's an error in the file itself. I don't think a fix is to be expected. You can, however, fix the file yourself in a few minutes with SLADE 3. Nothing in the actual rendering code is broken.

I have added a warning message so that the console log will tell you things more explicitly now:

Script error, "GZ-Models.pk3:modeldef.doom.items.def" line 3:
Unrecognized string " Path"

Seeing the space within the quoted string should warn people that there's a problem with an invisible character.

[Enjay]

OK, based on Gez's description, I think that I have fixed the modeldefs (doing a simple find/replace). They are attached for anyone who would rather not do it themselves. The zip only contains the modeldefs, not the full package.

[WinstonSmith6079]

Link in first post dead.

I was looking for both the DS-Models and the GZ-Models, like in .PK3 or whatever, but Googling is more Googling hehehehe

[ibm5155]

^
the latest version compiled: http://www.mediafire.com/download/91fuo ... mplete.pk3
But, you'll need to remove the skulltag models...

[WinstonSmith6079]

You mean just delete all the files in the root dir of the .PK3 that are filenamed 'Modeldef.Skulltag.*.def' and that's all?

Then it will work with like Doom, Heretic, and Hexen via GZDoom? And then I won't need any like DS- or GZ-Model .PK3s any more?

[WinstonSmith6079]

^
the latest version compiled: http://www.mediafire.com/download/91fuo ... mplete.pk3
But, you'll need to remove the skulltag models...

Well, I'm to guess that there's been no update to the model-pack since then?

I'd still like to be able to remove the Skulltag crap from it, whatwith Skulltag gone belly-up since some time ago.

Hmm, given that last, I'd of thought that the community would've had that standardly and readily accessible to downloaders.

So where currently is the latest 3D model- (and hi-rez texture-)pack for the Doom games and for Heretic: Shadow of the Serpent Riders that work best on GZDoom?