r16 Sprite Billboard options.

[Enjay]

OK, sticking my neck out here because I'm not convinced that I know what I'm doing but here goes my first "delving into the code" bug report. And it's a minor one.

When you start a clean install of GZdoom and go to the OpenGL options, the sprite billboard option is listed as "Unknown" and I *think* it's because of this:

gl_menu.cpp

Code: Select all

static value_t BillboardModes[] =
{
	{ 1.0, "Y Axis" },
	{ 2.0, "X/Y Axis" },
};

That defines options 1 and 2 (yes?)

but

gl_sprite.cpp

Code: Select all

CVAR(Int, gl_billboard_mode, 0, CVAR_ARCHIVE | CVAR_GLOBALCONFIG)

That, I think, sets the default option to 0, which has not been defined in gl_menu.cpp.

Is that any where near correct

(how many options should there be btw? Is there meant to be a 0? I can't figure it out)

[Graf Zahl]

I think Torr Samaho is the only one who can tell. I actually copied his code without looking too closely.

[Torr Samaho]

You are right, a default value of 0 is wrong. It should either be 1 (y axis billboard) or 2 (x/y axis billboard). In Skulltag the default is 2, but since you don't like the x/y axis billboard, Graf, I'd suggest that you change the default to 1 in GZDoom.

[Graf Zahl]

Changed. I made it so that the valid values are 0 and 1, not 1 and 2.