[356] Compile errors

[Enjay]

Not sure if this commit is a WiP or if it's supposed to compile, but it spits out a bunch of errors due to missing files:

Code: Select all

4>gl_vertex.cpp
4>.\src\gl\gl_vertex.cpp(45) : fatal error C1083: Cannot open include file: 'gl/gl_portal.h': No such file or directory
4>gl_texture.cpp
4>gl_sections.cpp
4>gl_scene.cpp
4>.\src\gl\gl_scene.cpp(51) : fatal error C1083: Cannot open include file: 'gl/gl_portal.h': No such file or directory
4>gl_models_md3.cpp
4>gl_models_md2.cpp
4>gl_models.cpp
4>gl_missingtexture.cpp
4>.\src\gl\gl_missingtexture.cpp(45) : fatal error C1083: Cannot open include file: 'gl/gl_portal.h': No such file or directory
4>gl_menu.cpp
4>Generating Code...
4>Compiling...
4>gl_light.cpp
4>.\src\gl\gl_light.cpp(51) : fatal error C1083: Cannot open include file: 'gl/gl_portal.h': No such file or directory
4>gl_hirestex.cpp
4>gl_glow.cpp
4>gl_framebuffer.cpp
4>gl_flats.cpp
4>c1xx : fatal error C1083: Cannot open source file: '.\src\gl\gl_flats.cpp': No such file or directory
4>gl_fakeflat.cpp
4>.\src\gl\gl_fakeflat.cpp(49) : fatal error C1083: Cannot open include file: 'gl/gl_portal.h': No such file or directory
4>gl_dynlight.cpp
4>gl_data.cpp
4>gl_bsp.cpp
4>.\src\gl\gl_bsp.cpp(49) : fatal error C1083: Cannot open include file: 'gl/gl_portal.h': No such file or directory

[Graf Zahl]

Why do you have to compile stuff 5 minutes after committing. Should already be fixed in r357 which was commutted shortly after this report.

[Enjay]

Why do you have to compile stuff 5 minutes after committing.

I didn't know it was only 5 minutes after committing: I didn't check the date stamp. All I did was run a batch file to check the repository before going to bed.

Commits usually compile. There is not usually a need to wait. Unless I am aware that you are about to commit again I can't know that waiting would achieve anything. Normally waiting would achieve nothing.

My report clearly indicates that I thought it may be a WiP but I was flagging up the problem in case it was not known about. It has happened before.

[Enjay]

Actually, I've been wondering if there is any way for you to flag up whether you have finished committing stuff for the day or not? I check the repository a number of times a day and usually there aren't too many commits in a single day so I just compile what's there and that's that. Sometimes (eg lately) there hasn't even been anything to compile for a couple or more days.

However, sometimes commits are made a number of times in a single day. On those occasions, I have no way of knowing if you are finished for the day or not, so I just compile what's there but then when I check back a little later I find a new commit. As a result, there have been times when I have put 3 or even 4 builds online in a single day. Unfortunately, I have no way of knowing how many commits you plan on doing or when you are likely to be finished so I just compile what's there when I check it.

If it's possible, could some simple comment be added to the changelog or something that lets me know you are done for the day? Perhaps a comment like "more to follow" if you aren't finished and something like "Done 23-06-09" that indicates when you are?

I realise that this won't always be possible or accurate (eg, if an unnoticed problematic bug is in a "final" commit for the day that you want to fix quickly). However, knowing that there is unlikely to be anything added for a reasonable period of time would save me making multiple builds and, more importantly on my Internet connection, spending a lot of time uploading them. It would also prevent me "compil[ing] stuff 5 minutes after committing" when you still have more to add to the repository.