r612 Rotating model inconsistencey between versions

[Enjay]

This may well be the result of something that has been fixed (in fact, I vaguely remember it being so) but I have spotted a difference between GZdoom versions so I thought I'd flag it up in case the current behaviour is incorrect.

If you load the attached zip, in 2.3.1 the model to the far right of the player seems to rotate about a point to the east of the N-S centre line of the map. In r612 it is to the west of the centre line instead.

deathstar.zip

(14.93 KiB) Downloaded 83 times

In addition, I also noticed a crash that can occur if a modeldef has a definition for a model but there is no corresponding actor. If you comment out one of the actors in the DECORATE of the example then try to start a new game from the menu, instead of starting map01 GZdoom drops out telling you about the modeldef error (which it always did, and should do), but it also gives a crash. This report was generated when commenting out test08 in the above attached file.

CrashReport.zip

(14.22 KiB) Downloaded 75 times

gzdoom-r612.map.gz

(533.29 KiB) Downloaded 82 times

[edit] r614 is the same as r612. [/edit]

[Graf Zahl]

Yes, I changed an inconsistency in the rotation code some revisions ago. There's 2 rendering paths and the math between them was different.