[fixed]Raising/Lowering 3d floors with Switches crashes

[mundungu]

I haven't seen anything about this yet, whether or not it is out there. I'm sure someone has run into this before, but I haven't seen mention of it (I haven't exactly combed the bugs threads, but I have scanned through them).

Raising the floor and ceiling of a 3d floor dummy sector does make the 3d sector rise, same thing for lowering making it fall. In an OPEN script, making a 3d floor rise or fall works perfectly fine for me, but that isn't what I want. If I use a switch to run the raise/lower scripts (the same scripts I tried as OPEN, but changed to (void) and applied to a switch with Linedef Action 81) it simply crashes GZDoom.

Please tell me that I am not just messing this up in some stupid way. As far as I can tell I'd be doing this correctly.

I've included the map in a .zip file whether or not this is a bug.

Very Fatal Error:
[spoiler]Code: ACCESS_VIOLATION
Tried to read address 0000001c
Flags: 00000000
Address: 0044369b

Windows NT 5.1 Build 2600 Service Pack 1

GS=0000 FS=0038 ES=0023 DS=0023
EAX=00000000 EBX=00000000 ECX=00000000 EDX=00000001
ESI=04da6110 EDI=00000001
EBP=00000200 EIP=0044369b ESP=0012fb84 CS=001b SS=0023
EFlags=00010246
CF- PF+ AF- ZF+ SF- TF- IF+ DF- OF- NT- RF+ VM- AC- VI- VP-

FPU State:
ControlWord=027f StatusWord=4000 TagWord=ffff
ErrorOffset=004807c0
ErrorSelector=075e001b
DataOffset=0063d194
DataSelector=ffff0023
Cr0NpxState=00000000

MM0=00000001000001ba
MM1=0000000000000000
MM2=8080817f7f800000
MM3=b400000000000000
MM4=0000000000000000
MM5=04da611000000001
MM6=0000020000000000
MM7=000000230012fb84

Running threads:
00000bfc at 0044369b*
0000045c
00000ea8
0000044c
000008b4
00000314
00000968
0000061c
0000088c

Loaded modules:
00400000 - 006e3fff *GZDoom.exe
77f50000 - 77ff6fff ntdll.dll
77e60000 - 77f45fff kernel32.dll
68b20000 - 68b3dfff GLU32.dll
77c10000 - 77c62fff msvcrt.dll
5ed00000 - 5edc5fff OPENGL32.dll
77dd0000 - 77e5cfff ADVAPI32.dll
78000000 - 78086fff RPCRT4.dll
7f000000 - 7f040fff GDI32.dll
77d40000 - 77dccfff USER32.dll
51000000 - 5104ffff DDRAW.dll
73bc0000 - 73bc5fff DCIMAN32.dll
10000000 - 10095fff fmod.dll
77be0000 - 77bf3fff MSACM32.dll
76b40000 - 76b6bfff WINMM.dll
4fec0000 - 4ffe5fff ole32.dll
71ad0000 - 71ad7fff WSOCK32.dll
71ab0000 - 71ac4fff WS2_32.dll
71aa0000 - 71aa7fff WS2HELP.dll
71950000 - 71a34fff COMCTL32.dll
70a70000 - 70ad5fff SHLWAPI.dll
006f0000 - 00877fff DevIL.dll
763b0000 - 763f4fff comdlg32.dll
7cd00000 - 7d4fafff SHELL32.dll
76390000 - 763abfff IMM32.DLL
629c0000 - 629c7fff LPK.DLL
72fa0000 - 72ff9fff USP10.dll
5ad70000 - 5ada3fff uxtheme.dll
04ed0000 - 04efafff msctfime.ime
74720000 - 74763fff Msctf.dll
76f50000 - 76f57fff wtsapi32.dll
76360000 - 7636efff WINSTA.dll
76f90000 - 76f9ffff Secur32.dll
51080000 - 510e0fff dsound.dll
77c00000 - 77c06fff VERSION.dll
72d20000 - 72d28fff wdmaud.drv
72d10000 - 72d17fff msacm32.drv
77bd0000 - 77bd6fff midimap.dll
5ef80000 - 5ef83fff KsUser.dll
7c890000 - 7c90ffff CLBCATQ.DLL
77120000 - 771aafff OLEAUT32.dll
77050000 - 77114fff COMRes.dll
6ce10000 - 6ce44fff dinput8.dll
688f0000 - 688f8fff HID.DLL
76670000 - 76756fff SETUPAPI.DLL
69500000 - 6986afff nvoglnt.dll
746f0000 - 74715fff Msimtf.dll
00e60000 - 00e70fff r_opengl.dll

Bytes near EIP:
0044368b: fc ff 83 c4 10 5e c3 a1 b0 50 64 00 8b 54 24 08
0044369b: 8b 44 90 18 85 c0 74 07 c7 40 28 01 00 00 00 5e
004436ab: c3 cc cc cc cc 56 8b 74 24 0c 6a 08 56 68 8c f2

ZDoom version 2.0.96x (0.9.11)

Command line:
C:\games\zdoom\GZDoom.exe -iwad DOOM2.WAD -file C:\games\zdoom\tempmap.wad -map MAP01 -skill 3
IWAD: DOOM2.WAD

Current map: MAP01

viewx = -18510348
viewy = -82301157
viewz = 2792117
viewangle = 4217372672

Possible call trace:
0044369b BOOM
0045a8c0 call 00443620
00479334
0045da1d call 004792c0
004648ee call [esp+0x18]
00465088 call 004648a0
0045d920
0045dc5d call 00464c40
0045d920
00480c64 call 0045dc10
0047e423 call 004804c0
0042a535 call 0047e350
0041c5a0 call 0042a200
004183ac call 0041c2a0
00561566
0040b871 call 0040b7c0
0040b871 call 0040b7c0
0053a0f1 call 0040b860
0053a1f3 call 0054f21a
00560fdb
00537c8d call 00418410
00537fc6 call 00537890
00552b19 call 00537f50
005529ad call 0054ffc0
004d004f
00552995

Stack Contents:
0012fb84: 013dff30 0045a8c0 00000001 04da6110 0·=···E······a··
0012fb94: 00479334 013dff30 013e4cb8 00000000 4·G·0·=··L>·····
0012fba4: 00000001 00000001 00000000 00000000 ················
0012fbb4: 00000000 00000000 04d682dc 00010000 ················
0012fbc4: 00000001 013e4cb8 0045da1d 013dff30 ·····L>···E·0·=·
0012fbd4: 013e4cb8 00000000 00000001 04d682dc ·L>·············
0012fbe4: 004648ee 04d682dc 00000003 00000001 ·HF·············
0012fbf4: 00000000 00000001 00465088 0045d920 ·········PF· ·E·
0012fc04: 00010000 fb09f313 ff65c275 fb185993 ········u·e··Y··
0012fc14: fee69575 00000001 0102cd2a 00000001 u·······*·······
0012fc24: 00000002 00000001 00000001 00000003 ················
0012fc34: 0045dc5d 00000004 01000000 ffffe304 ]·E·············
0012fc44: 00018df5 00000003 0045d920 013e4cb8 ········ ·E··L>·
0012fc54: 0063d140 00000200 00000010 00480c64 @·c·········d·H·
0012fc64: 0063d140 00000000 0063d140 00000001 @·c·····@·c·····
0012fc74: 00000000 00380000 00380000 0047e423 ······8···8·#·G·
0012fc84: 0000003f 00000068 00000001 0042a535 ?···h·······5·B·
0012fc94: 0063e706 0000001f 7a295e95 0041c5a0 ··c······^)z··A·
0012fca4: 0000026e 013c1fc8 0012fcdc 00000001 n·····<·········
0012fcb4: 004183ac 0000026e 013c1fc8 00000001 ··A·n·····<·····
0012fcc4: 00561566 00000067 0012fcb8 0012fe04 f·V·g···········
0012fcd4: 005611a0 00000000 00000004 00000000 ··V·············
0012fce4: 0012fe68 0000017e 0000001d 04d84e98 h···~········N··
0012fcf4: 77fa88f0 77f51c88 6d6f6f44 7475412e ···w···wDoom.Aut
0012fd04: 616f6c6f 732f0064 736e696b 0012fd00 oload·/skins····
0012fd14: 00000000 77f60f67 77fc1774 77f60ab7 ····g··wt··w···w
0012fd24: 77e754ce 00000000 00000000 00000000 ·T·w············
0012fd34: 00000000 c0000135 0012f8e4 77e75357 ····5·······WS·w
0012fd44: 005d9d40 75e33fd4 0040b871 00000002 @·]··?·uq·@·····
0012fd54: 005d9d38 75e33fd4 0040b871 00000002 8·]··?·uq·@·····
0012fd64: 005d9d38 0012fd74 0053a0f1 005d9d38 8·]·t·····S·8·]·
0012fd74: 0053a1f3 00000094 00000005 00000001 ··S·············
0012fd84: 00000a28 00000002 76726553 20656369 (·······Service
0012fd94: 6b636150 00003120 005c0032 00700072 Pack 1··2·\·r·p·
0012fda4: 763a0a2b 00000010 763a0a5e 763a12d3 +·:v····^·:v··:v
0012fdb4: 4ff48431 0015f178 00000001 4ff4844c 1··Ox·······L··O
0012fdc4: 0015f178 00000001 00000001 00000002 x···············
0012fdd4: 0012fdfc 4feddc06 00000001 00000000 ·······O········
0012fde4: 00000002 00000000 00000000 0000026e ············n···
0012fdf4: 75e33fd4 0012fe5c 00560fdb 75e33fd4 ·?·u\·····V··?·u
0012fe04: 0012fe5c 005611be ffffffff 00537c8d \·····V······|S·
0012fe14: ffffffff 77e7e60c 7ffdf000 00000000 ·······w·······
0012fe24: 00000000 0000026e 0000017e 00000001 ····n···~·······
0012fe34: 000f4240 0012fe2c 00000020 000001a0 @B··,··· ·······
0012fe44: 00000276 00400000 00400250 00400228 v·····@·P·@·(·@·
0012fe54: 77e60000 0012fe14 0012fe88 00563740 ···w········@7V·
0012fe64: 00000000 0012fe98 00537fc6 00400000 ·········S···@·
0012fe74: 77e7acd9 00000000 7ffdf000 0012fe74 ···w·······t···
0012fe84: 0012f7ac 0012ffb0 0055280c 005d96d0 ·········(U···]·
0012fe94: 00000000 0012ffc0 00552b19 00400000 ·········+U···@·
0012fea4: 00000000 0015232c 00000005 00000094 ····,#··········
0012feb4: 00000005 00000001 00000a28 00000002 ········(·······
0012fec4: 76726553 20656369 6b636150 f5003120 Service Pack 1··
0012fed4: f5513c14 f5513c14 f5513c14 f5513c14 ·<Q··<Q··<Q··<Q·
0012fee4: f5513c14 f5513c14 f5513c14 e5420000 ·<Q··<Q··<Q···B·
0012fef4: e5421000 e5422000 e5423000 e5424000 ··B·· B··0B··@B·
0012ff04: e5425000 e5426000 e5427000 e5428000 ·PB··`B··pB···B·
0012ff14: e5429000 e542a000 e542b000 e542c000 ··B···B···B···B·
0012ff24: e542d000 e542e000 81e063a8 ff676980 ··B···B··c···ig·
0012ff34: 0001f79e 00000001 0000000f 005529ad ·············)U·
0012ff44: 70a7411b 80000002 7ffdf000 00000044 ·A·p·······D···
0012ff54: 00153540 00153398 001535a0 00000000 @5···3···5······
0012ff64: 00000000 00000000 00000000 00000000 ················
0012ff74: 00000000 00000000 00000001 00000005 ················
0012ff84: 00000000 ffffffff ffffffff ffffffff ················
0012ff94: 00080000 00000000 81833240 0015232c ········@2··,#··
0012ffa4: 00000000 0012feb0 00000001 0012ffe0 ················
0012ffb4: 0055280c 005dca58 00000000 0012fff0 ·(U·X·]·········
0012ffc4: 77e8141a 70a7411b 80000002 7ffdf000 ···w·A·p·······
0012ffd4: 005a0047 0012ffc8 004d004f ffffffff G·Z·····O·M·····
0012ffe4: 77e9b2e5 77e97ce0 00000000 00000000 ···w·|·w········
0012fff4: 00000000 00552995 00000000 ·····)U·····[/spoiler]

[Graf Zahl]

Interesting bug you found here. You accidentally used 'suspend script' instead of 'execute script'. Buz ZDoom fails to check whether any scripts have been started before trying to suspend them. It has nothing to do with 3D-floors. The WAD crashes the same when started in ZDoom.

Fixed in GZDoom though - although you have to fix your WAD as well.

[mundungu]

D'oh, dumber mistake than I thought.