r1297 and older: very minor issue with ambient light slider

[Enjay]

I suppose this could affect other sliders but I have only spotted it with the ambient light level one.

The maximum value on the slider is 255.0. If you turn it up to max, then start coming down it comes down in increments of 5. So you get values such as 250, 245, 240, 235 etc.

However, the minimum value on the slider is 1.0. If you turn it all the way down and then start going up again, it still moves in increments of 5 so you get values like 6, 11, 16, 21 etc.

Like I said, minor issue.

[edit] Hmmm, I tried setting the minimum value to 0.0 in menudef but the slider still only went down to 1.0 in game. Maybe I did something wrong though. [/edit]

[Gez]

What fix do you prefer: a minimum value of 5, or a 1-increment step? (You can test either by editing the menudef.z lump in gzdoom.pk3.)

[Enjay]

The increment step of 1 was a pain in the neck to try and slide all the way but then no one should really be wanting to do that other than just to see how far it goes and I don't suppose many people touch the setting very often anyway.

The 5 increment step is easier but if it ties people to a minimum value of 5 I'm going to guess that there might be a visible difference in some lighting modes on some people's machines between 1.0 and 5.0 so, if that is the case, I don't think the menu should artificially prevent them from setting values below 5.0 with the slider.

If the concern in paragraph 2 is a valid one, then the 1 unit increment would be better than the min value of 5.0 IMO.

[Graf Zahl]

For the record, I reverted this change as it makes the slider behave in an unacceptable way.

[Enjay]

Is there any way that the value range for the slider can be set to 0.0-255.0 or is 0.0 not an acceptable value?

[edit] Hmmm, the menu code accepts 256.0 as a max value and this removes the anomaly. Is 256 an acceptable max value? [/edit]

[Graf Zahl]

Any larger value is rather pointless but above 255 you won't see any further differences because light can't be brighter.