r1449 Brightness slider

Bugs that have been resolved.

Moderator: Graf Zahl

Locked
User avatar
Enjay
Developer
Developer
Posts: 4748
Joined: Tue Aug 30, 2005 23:19
Location: Scotland
Contact:

r1449 Brightness slider

Post by Enjay »

The brightness slider is behaving quite differently in GZDoom compared with ZDoom.

First, there is the width:

[spoiler]Image

Image[/spoiler]

The slider is shorter in ZDoom.

The longer slider in GZDoom means (at my resolution) the numbers can fall off the edge of the screen when negative numbers are being displayed.

However, that may be an irrelevant issue because the number range is also different. In ZDoom the slider can go from 0.75 to 3.00. In GZDoom the values are a displayed -0.8 to 0.8. However, I think they are actually -0.85 to 0.85 which brings me on to...

ZDoom displays two decimal places whereas GZDoom only displays one. This is a problem because the slider now moves in increments of 0.05 and therefore GZDoom can't display the full number for values ending in *.*5.

I've checked the MENUDEF and ZDoom and GZDoom both have:

Code: Select all

Slider "Brightness",				"Gamma", 0.75, 3.0, 0.05, 2
So the difference must be hiding elsewhere.

[edit] Heh, going back to the official versions of ZDoom and GZDoom it appears that some of these differences have been there for some time. [/edit]

[edit2] Actually, shouldn't the brightness slider be affecting "vid_brightness" rather than "Gamma"? [/edit2]
User avatar
Gez
Developer
Developer
Posts: 1399
Joined: Mon Oct 22, 2007 16:47

Re: r1449 Brightness slider

Post by Gez »

There's a switcheroo going on. Gamma is called Brightness in ZDoom; but it's called Gamma in GZDoom. Brightness corresponds to something else that doesn't exist in ZDoom. So you should compare ZDoom's Brightness with GZDoom's Gamma.


As for the different slider widths, I don't have that.
[spoiler]Image[/spoiler]
User avatar
Enjay
Developer
Developer
Posts: 4748
Joined: Tue Aug 30, 2005 23:19
Location: Scotland
Contact:

Re: r1449 Brightness slider

Post by Enjay »

So it makes sense for the GZDoom brightness slider to work differently to the ZDoom one because they are altering different things.

I've made up a gif similar to yours so that you can see the full screen (albeit size reduced) menu from my screen. As you can see, my gamma slider in GZDoom seems to be the same length as the brightness one in ZDoom.

[spoiler]Image[/spoiler]

I noticed that you seem to be using one of the hi-res filter modes so I tried them and that made no difference. So I tried running in a window - no difference. Then I tried running at 1382x806 (well, that's what I put on the command line but it actually ran in 1400x900 which I assume was the nearest available value) as per your screenshots and doing so made all my sliders the same length (in both GZDoom and ZDoom). So the slider length "problem" (if indeed it is a problem) seems to be resolution related but I guess that's ZDoom rather than GZDoom related. I'll post about that in the ZDoom forum. (Done.)

Can I ask a question about Gamma versus vid_brightness? Obviously they both affect how bright the screen is but they do it in different ways. What are the implications of altering gamma rather than vid_brightness (ie what the differences in what they do) and which would be best to alter in which set of circumstances?
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Re: r1449 Brightness slider

Post by Graf Zahl »

ZDoom's brightness really is gamma.

GZDoom allows to change more settings so the names had to be adjusted. Brighness in GZDoom corresponds to what most monitors do when changing brightness.
User avatar
Enjay
Developer
Developer
Posts: 4748
Joined: Tue Aug 30, 2005 23:19
Location: Scotland
Contact:

Re: r1449 Brightness slider

Post by Enjay »

OK, thanks.

I've done a bit of reading up on gamma now and have a better (though far from in depth) idea of what gamma adjustment is versus brightness. I always knew that they were a bit different but I wasn't really sure how.
Locked

Return to “Closed Bugs”