[1.8-1.9.569] Bug : some 3D models are not shown

Bugs that have been resolved.

Moderator: Graf Zahl

Locked
User avatar
ivan
Posts: 4
Joined: Thu Sep 02, 2010 17:57

[1.8-1.9.569] Bug : some 3D models are not shown

Post by ivan »

Hi,
my system is a Windows 7 Ultimate x64 Service Pack 1, 8Gb RAM, Intel Core2 Quad CPU Q9450, NVIDIA GeForce GTX 260.
I'm using WinRAR 4.01 x64 to create the PK3 files (version 5 does not create compatible ZIPs, afaik).

My problem is that since version 1.8 some of the models in my mod are not shown:
  • 1.5.3.990, 1.5.6.1104
    • Models are shown; it does not take in count the angle modifications introduced in the modeldefs file but all of them are shown.
    1.7.1.1526
    • All models are shown perfectly.
    1.8.0.1597, 1.8.2.0, 1.8.3.0, 1.8.4.0, G1.9pre-569
    • Some of the models are not shown; dmd, md2 and md3 models as well. I could not find a clear pattern (nor in the modeldef file nor in the actors definition) to find out why some of them are shown and others aren't.
Long story short, here's a couple of screenshots of the same frame in GZDoom 1.7 and 1.8:

Image Image

I'm stuck with version 1.7 as it's the newest working as expected.
Attachments
test_doom2.pk3
This mod replaces original "Candelabra" and "CandleStick" and adds their 3D models. Sample map included.
(267.75 KiB) Downloaded 59 times
User avatar
Enjay
Developer
Developer
Posts: 4748
Joined: Tue Aug 30, 2005 23:19
Location: Scotland
Contact:

Re: [1.8-1.9.569] Bug : some 3D models are not shown

Post by Enjay »

If you check the console after starting the map, you get this:

Code: Select all

Script error, "test_doom2.pk3:modeldef.txt" line 3:
Unrecognized string " Path"
Script error, "test_doom2.pk3:modeldef.txt" line 3:
Unrecognized string "Models/XSCandelabra1"
Script error, "test_doom2.pk3:modeldef.txt" line 4:
Unrecognized string " Model"
Script error, "test_doom2.pk3:modeldef.txt" line 4:
Unrecognized string "0"
Script error, "test_doom2.pk3:modeldef.txt" line 4:
Unrecognized string "Candelabra1.md2"
Script error, "test_doom2.pk3:modeldef.txt" line 5:
Unrecognized string " Skin"
Script error, "test_doom2.pk3:modeldef.txt" line 5:
Unrecognized string "0"
Script error, "test_doom2.pk3:modeldef.txt" line 5:
Unrecognized string "candelabra.png"
Script error, "test_doom2.pk3:modeldef.txt" line 6:
Unrecognized string " Model"
Script error, "test_doom2.pk3:modeldef.txt" line 6:
Unrecognized string "1"
Script error, "test_doom2.pk3:modeldef.txt" line 6:
Unrecognized string "Candelabra2.md2"
Script error, "test_doom2.pk3:modeldef.txt" line 7:
Unrecognized string " Skin"
Script error, "test_doom2.pk3:modeldef.txt" line 7:
Unrecognized string "1"
Script error, "test_doom2.pk3:modeldef.txt" line 7:
Unrecognized string "candleflame1.png"
Script error, "test_doom2.pk3:modeldef.txt" line 8:
Unrecognized string " Scale"
Script error, "test_doom2.pk3:modeldef.txt" line 8:
Unrecognized string "1.0"
Script error, "test_doom2.pk3:modeldef.txt" line 8:
Unrecognized string "1.0"
Script error, "test_doom2.pk3:modeldef.txt" line 8:
Unrecognized string "1.0"
I looked at your MODELDEF and I couldn't see anything obvious wrong with it but I re-did it...

Code: Select all

Model XSCandelabra1
{
	Path "Models/XSCandelabra1"
	Model 0 "Candelabra1.md2"
	Skin 0 "candelabra.png"
	Model 1 "Candelabra2.md2"
	Skin 1 "candleflame1.png"
	Scale 1.0 1.0 1.0

	FrameIndex 0035 A 0 0
}

Model XSCandle1
{
	Path "Models/XSCandle1"
	Model 0 "Candlestick.md2"
	Skin 0 "Candlestik_y.png"
	Model 1 "Candleflame.md2"
	Skin 1 "candleflame_y.png"
	Scale 0.5 0.5 0.5

	FrameIndex 0039 A 0 0
}
and that worked.

My guess is that whatever text editor you used put something in there other than regular white space characters and this confused GZDoom.

[edit] Looking at it in a hex editor, there does seem to be *something* before the word "path" (and others).

Image

Don't know what character A0 is though.
User avatar
Graf Zahl
GZDoom Developer
GZDoom Developer
Posts: 7148
Joined: Wed Jul 20, 2005 9:48
Location: Germany
Contact:

Re: [1.8-1.9.569] Bug : some 3D models are not shown

Post by Graf Zahl »

0xa0 is a 'fixed space', i.e. it's not apparent in the editor - but it's enough to throw the parser off the rails.
In older versions there was a bug in the parser that let it skip over some bogus parts.
User avatar
ivan
Posts: 4
Joined: Thu Sep 02, 2010 17:57

Re: [1.8-1.9.569] Bug : some 3D models are not shown

Post by ivan »

Oh my! You're right. I don't think Notepad++ introduced that 0xA0; it's surely been added by inserting someone else's code... and, of course, the Copy & Paste virus did the rest of the job (141 appearances in the light sources modeldef file)... Many thanks, that thing was driving me crazy.
Locked

Return to “Closed Bugs”