[1.5.01] Dynamic lights messing up sector lighting

[Rex Claussen]

The new GZDooM version (1.5.01) seems to mess up dynamic lighting. Here's what I have:

1. Several sectors with ceiling FLATS as lights
2. Light value in those sectors the same as surrounding sectors
3. Transfer_CeilingLight special to brighten up the ceiling FLATS
4. Dynamic lights (some of them colored), that are large enough to light the floors.

In v1.5.0 everything was working fine. In V1.5.01, here's what happens:

1. Either the entire light sector is being brightened, or a Transfer_FloorLight special is also being applied.
2. The dynamic lighting in sectors with the Transfer_CeilingLight special is not working. However, the color is being applied to the floor.
3. If the sector does not have a light special, the dynamic lights work but seem to have a washed-out effect and don't brighten the volume like they used to.

Transfer_Ceiling Light seems to be transferring floor light. Plus no dynamic lighting on floor.

DynLite1.jpg (77.33 KiB) Viewed 2067 times

Dynamic lighting is washed-out. Note that the light texture itself is not brightened whatsoever. [Note: No sector light special used.]

DynLite2.jpg (37.83 KiB) Viewed 2067 times

Same problem as DynLite1, but the absence of dynamic lighting is more noticeable.

DynLite3.jpg (34.08 KiB) Viewed 2067 times

[Rex Claussen]

I'm adding another example because of the 3-file upload limit.

Same problem as in DynLite1 & 3, but note complete absence of red dynamic lighting.

DynLite4.jpg (63.22 KiB) Viewed 2066 times

I just noticed this additional weirdness.

1. The blue-white oval shows that only one part of the sector is being lit up, even though the light thing is squarely in the middle of that sector.
2. The green oval shows that the edge of the sector is properly lit up.
3. The yellow oval shows that the edge of the sector (which should be lit up like in 2, above) is not lit up at all.

Incomplete lighting within a sector.

DynLite5.jpg (54.79 KiB) Viewed 2065 times

[Rex Claussen]

And upon further investigation, it appears that the dynamic light may be lighting up the entire sector using the value in the Transfer_CeilingLight special (in this case = 160). [A notable exception is in DynLite5.jpg, above, where only a part of teh sector appears to be brightened.] Here is an example of when the player is outside the light sector, and what happens when the player steps into the light sector.

Outside the light sector.

DynLite6.jpg (64.32 KiB) Viewed 2065 times

Inside the light sector.

DynLite7.jpg (61.15 KiB) Viewed 2065 times

[Rex Claussen]

And here's another example showing that the colored lighting is indeed being applied to the entire volume (i.e., not just the floor, as seen in DynLite2-4, above).

Outside the colored light sector.

DynLite8.jpg (62.89 KiB) Viewed 2065 times

Inside the colored light sector.

DynLite9.jpg (60.64 KiB) Viewed 2065 times

[Salad Viking]

What is happening seems to be that dynamic lights only light up the subsector they are in.

[spoiler][/spoiler]

[Graf Zahl]

Hm, looks like Randy's 'optimizations' did break something after all which I did not catch yesterday...

[Graf Zahl]

Fixed. As supspected this was a result of Randy's 'optimization' not working correctly. To be precise, the internal node builder no longer exported the partner segs correctly.