Missing colored light with compat renderer

[_mental_]

It seems that after incorporating both renderers in GZDoom 2.x some colored lights are not applied on walls.
Here is the screenshot from Extreme Terror map. Archs are violet with the modern renderer but not with the compatibility one:

exterror_colored_light_.jpg (42.06 KiB) Viewed 632 times

To be honest at the moment I don't know where in the code I need to look in order to figure out what's wrong with the lighting.

[_mental_]

It appeared that combination of fog and lights are not handled with compatibility renderer. The picture is now equal to 1.9.1 (more on this below). Pull request is here.

I didn't commit directly for two reasons:

• I'm not sure about conditions in GLFlat::DrawSubsectorLights() and GLWall::RenderLightsCompat() functions (MF2_DORMANT flag check). I left them as is however they probably should be updated.
• Rendered picture is still different from the modern renderer. The same problem was with 1.9.1 vs 2.1.1 releases.

---

exterror_gl45.jpg (42.28 KiB) Viewed 614 times

---

exterror_gl21.jpg (35.66 KiB) Viewed 614 times

The question is: what is the correct version?

[Graf Zahl]

The effect looks different because with texture overlays I only can do additive lights. The shader is not limited to this.

[_mental_]

I guess nothing can be done about the second question. But what about the first one and the proposed fix in general?

[Graf Zahl]

I'm a bit short on time to do proper tests but it looks correct.

[_mental_]

After some testing I pushed this change along with the similar fix for missing decals in conjunction with dynamic lights.
The topic can be moved to Closed Bugs subforum.